217358 - Chatzilla should use prompt service instead of alert

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

One of our UI guidelines is to use the prompt service instead of alert(). I
can't remember the exact reasoning, but maybe alert() in chrome locks the whole
app or something.

See p3p for an example on how to use the prompt service.

Comment 1

[James Ross]

According to #mozilla, "prompt service dialogs are distinguished as
trustworthy," whatever that means. :)  We can at least set the title on them to
something sensible, rather than "Alert".

--> Taking.

Comment 2

[James Ross]

D'oh, silly Bugzilla.

Comment 3

[Robert Ginda]

http://lxr.mozilla.org/mozilla/source/extensions/venkman/resources/content/venkman-utils.js#226

You should just need to add the alert, confirm, and prompt functions from
venkman-utils.js into chatzilla's utils.js

Comment 4

[James Ross]

Attachment: "Borrow" from Venkman

This patch just adds the Venkman alert/confirm/prompt functions, as suggested
by rginda. I have confirmed that calls from the *client* tab are now using
these functions, but couldn't check Chatzilla itself because bug 213782.

Comment 5

[Robert Ginda]

Comment on attachment 131628 [details] [diff] [review]
"Borrow" from Venkman

r=rginda

Comment 6

[Robert Ginda]

fixed in 0.9.40