Closed
Bug 217432
Opened 22 years ago
Closed 22 years ago
finger/datetime channel always return failure on suspend/resume
Categories
(Core :: Networking, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: Biesinger, Assigned: Biesinger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.88 KB,
patch
|
darin.moz
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
124 NS_IMETHODIMP
125 nsDateTimeChannel::Suspend()
126 {
127 if (mPump)
128 mPump->Suspend();
129 return NS_ERROR_UNEXPECTED;
130 }
131
132 NS_IMETHODIMP
133 nsDateTimeChannel::Resume()
134 {
135 if (mPump)
136 mPump->Resume();
137 return NS_ERROR_UNEXPECTED;
138 }
(finger channel does the same)
Shouldn't the mPump-> calls look like |return mPump->Suspend();|?
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #130456 -
Flags: superreview?(bz-vacation)
Attachment #130456 -
Flags: review?(darin)
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.6alpha
|
||
Comment 2•22 years ago
|
||
Comment on attachment 130456 [details] [diff] [review]
patch
sr=bzbarsky
Attachment #130456 -
Flags: superreview?(bz-vacation) → superreview+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 130456 [details] [diff] [review]
patch
sr=darin (doh!)
Attachment #130456 -
Flags: review?(darin) → review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Checking in datetime/nsDateTimeChannel.cpp;
/cvsroot/mozilla/extensions/datetime/nsDateTimeChannel.cpp,v <-- nsDateTimeCha
nnel.cpp
new revision: 1.32; previous revision: 1.31
done
Checking in finger/nsFingerChannel.cpp;
/cvsroot/mozilla/extensions/finger/nsFingerChannel.cpp,v <-- nsFingerChannel.c
pp
new revision: 1.45; previous revision: 1.44
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•