217433 - make datachannel support suspend/resume

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Currently, the data channel doesn't support suspending/resuming... would be good
if it did, at least during OnStartRequest.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Darin Fisher]

hmm... looks more complicated then it should need to be :(

let me think about this one some....

Comment 3

[Darin Fisher]

ok, since mDataStream is the input end of a pipe, it supports nsIAsyncInputStream.  
as a result, it will work well with nsIInputStreamPump, which supports all the
Suspend,Resume,nsIStreamListener semantics that we want here.  i think it would
be better to utilize nsIInputStreamPump here (probably less code too).

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: use nsIInputStreamPump

unfortunately, this does not quite work yet... for some reason, I get JS Errors
from chrome, because one request can't be QId to nsIChannel...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 130459 [details] [diff] [review]
patch

marking review- per above comments

Comment 6

[Darin Fisher]

make sure the nsIRequest corresponding to the input stream pump is not getting
leaked out of the data channel.  callbacks from the data channel must pass a
nsIRequest that is the data channel.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

adding the right request (namely, not the pump) to the loadgroup helped...

Comment 8

[Darin Fisher]

Comment on attachment 132694 [details] [diff] [review]
patch

patch looks good.. two nits:

1-  use NS_INPUTSTREAMPUMP_CONTRACTID instead of raw string contract-id.  for
necko,
    this is preferred.

2-  eliminate use of (void) prefix.  personal pet pieve... looks like noise to
me.
    since it seems that you are just preserving it in your patch, i'm hopeful
that
    you won't object ;)

r=darin

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: nits fixed

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132959 [details] [diff] [review]
nits fixed

sr=bzbarsky

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in src/nsDataChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/data/src/nsDataChannel.cpp,v  <-- 
nsDataChannel.cpp
new revision: 1.67; previous revision: 1.66
done
Checking in src/nsDataChannel.h;
/cvsroot/mozilla/netwerk/protocol/data/src/nsDataChannel.h,v  <--  nsDataChannel.h
new revision: 1.22; previous revision: 1.21
done