217531 - mozilla .xpi files' install.js has filesize too big

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect, P2)

Description

[Phil Pishioneri]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624

Both the network installer and sea tar archive of 1.5b are failing to install
for me on Red Hat Linux 7.3 (haven't tried the other).

During installation I get a pop-up window with

  Error[-621]: An Installer module browser.xpi (.xpi) failed to install

and the installation fails.

In the install.log, I see this:

     Mozilla Navigator (version 1.5.0.2003082705)
     -----------------

     ** initInstall: 0
     ** communicatorFolder: /usr/local/mozilla/active/
     ** Insufficient disk space: /usr/local/mozilla/active/
     **   required : 163875 K
     **   available: 63203 K

     Install **FAILED** with error -235  --  08/27/2003 22:42:11

Should the browser portion be requiring 162MB of disk space?

Reproducible: Always

Steps to Reproduce:

Comment 1

[Andrew Schultz]

worksforme.  did you grab the 1.5b binary build from .mozilla.org?

I think the installer gets its info on size from config.ini (in the installer
directory).  What does your config.ini look like for the Navigator component
(Install Size=xxxx)?  Mine says "25765"

Comment 2

[Phil Pishioneri]

Yes, I used the 1.5b binary builds from ftp.mozilla.org: both the installer and
sea-tar failed.  The config.ini stanzas for Navigator had "Install Size=25765".

I just tried the 1.5a installer (had skipped that release), and it has the same
problem.

I re-installed 1.4 via its installer, and it installed without any problem.

Comment 3

[Phil Pishioneri]

I've found where the required size of 163875 comes from: it's hardcoded in the
installation code.

The file install.js which is packaged in browser.xpi has this line:

    var srDest = 163875;

and that variable is used in that file's function verifyDiskSpace as the amount
(in Kbytes) of free space required.

The variable in the 1.4 version of install.js is set to 22987.

So there's a discrepancy between the value in config.ini (apparently not
actually used by the code) and the one in install.js (which seems abnormally high).

If you have about 180 megabytes free in your installation filesystem, you
probably don't see this error.

Comment 4

[Phil Pishioneri]

I generated a new browser.xpi with a modified install.js (changed srDest to
30000), and was able to install 1.5b.

Total space used in the filesytem by the installation was about 44000 Kbytes, so
the value in install.js appears incorrect.

Comment 5

[Andrew Schultz]

ok, I see that.  It looks like it's a problem with all the xpi files (not just
browser).

Comment 6

[Henrik Gemal]

->build

Comment 7

[Andrew Schultz]

http://lxr.mozilla.org/mozilla/source/xpinstall/packager/unix/makeall.pl#108
108 sub MakeXpiFile
109 {
110   my($componentName) = @_;
111 
112   # Make .js file
113   MakeJsFile($componentName);
114 
115   # Make .xpi file
116   if(system("perl makexpi.pl $componentName $inStagePath $inDistPath") != 0)
117   {
118     exit(1);
119   }
120 }

the JS file is made first and then it's stripped (in makexpi.pl), so the size
calculated for the install.js is the size with the libs unstripped.

Comment 8

[cls]

-> installer

Comment 9

[Andrew Schultz]

Attachment: patch

This moves the call to makejs.pl inside of makexpi.pl (after the libs have been
stripped) and fixes the bug for me.

Comment 10

[Andrew Schultz]

-> me

Comment 11

[Alexander Opitz]

Any news on this patch?

Comment 12

[Alexander Opitz]

*** Bug 231116 has been marked as a duplicate of this bug. ***

Comment 13

[Alexander Opitz]

*** Bug 231567 has been marked as a duplicate of this bug. ***

Comment 14

[Alexander Opitz]

*** Bug 218156 has been marked as a duplicate of this bug. ***

Comment 15

[Andrew McGuinness]

No-one has mentioned how to work around this if you're stuck (as I was):
xpi files are zip files, so they can be unpacked with info-zip, winzip, jar,
etc. and the "install.js" file edited to modify the "srDest" line as described
in earlier comments, then pack up back into a zip file with the original name
and the installer will work.  I had to do browser.xpi and mail.xpi.

Comment 16

[Friedrich Lobenstock]

(In reply to comment #15)
> No-one has mentioned how to work around this if you're stuck (as I was):...

As I did: 
Temporarily free some space on the partition where you are going to installing
mozilla by moving stuff somewhere else and back again when the install of
mozilla finished. I know not always an option but you asked for work-arounds ;-)

AFAIR you need to have 160/180MB of free space when not changing the xpi files.

Comment 17

[Daniel (Leaf) Nunes]

Comment on attachment 131400 [details] [diff] [review]
patch

sr=leaf (nice one, samir!)

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in