Closed Bug 217750 Opened 21 years ago Closed 21 years ago

chatzilla doesn't show PART reasons

Categories

(Other Applications :: ChatZilla, defect)

Product:
Other Applications
Component:
ChatZilla
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: samuel, Assigned: rginda)

References

Details

(Whiteboard: cz-patch)

Attachments

(1 file, 1 obsolete file)

the test was backwards
2.29 KB, patch
rginda
: review+
Details | Diff | Splinter Review 
when someone gives a reason with /part, chatzilla won't display it.
Summary: chatzilla does show PART reasons → chatzilla doesn't show PART reasons
Attached patch show part reason (obsolete) — — Splinter Review 

    
  

        Attachment #130599 -
        Flags: review?(rginda)

    
    

    
  
*** Bug 217748 has been marked as a duplicate of this bug. ***

    
  

        Attachment #130599 -
        Flags: review?(rginda)

    
    

    
  


  

        Attachment #130599 -
        Attachment is obsolete: true

    
  

        Attachment #130600 -
        Flags: review?(rginda)

    
    

    
  
Comment on attachment 130600 [details] [diff] [review]
the test was backwards

this looks great, except I think that e.params[2] array access will cause
strict warnings if the param isn't there.  r=rginda with that fixed.

        Attachment #130600 -
        Flags: review?(rginda) → review+

    
  

        Attachment #130600 -
        Flags: approval1.5?

    
  

        Attachment #130600 -
        Flags: approval1.5?

    
  
Whiteboard: cz-patch

    
    

    
  
0.9.44 seems to quite happily show part reasons, though it doesn't seem to show
your own part message.

    
    

    
  
This has been checked in, and works, so marking FIXED. If it does not work
correctly, please reopen this bug.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Other Applications

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: