217875 - Selecting "Download more" from the language part of the spellchecker dialog results in a freeze

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Küstner]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030827
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030827

Attempt of downloading additional dictionaries results in a hang.

Reproducible: Always

Steps to Reproduce:
1. Start editing a new mail or a web page in Composer.
2. Press Ctrl-K or the Spell button in the Toolbar.
3. Go to Language -> Download More.

Actual Results:  
An empty browser window opens. The composing window and the spellchecker dialog
are frozen. Browsing is still possible but Mozilla can not be exited - it has to
be killed.

Expected Results:  
The ability of downloading additional dictionaries.

Not sure if critical is the right severity, but it has "hang" in its description.

Comment 1

[Andrew Schultz]

> Browsing is still possible but Mozilla can not be exited - it has to be killed.

the spellchecker and compose window are waiting for you to close the browser
window.  once you do that, the spellchecker will be responsive again (and
exitting Mozilla is possible).

Is that not what you see?

Comment 2

[Christian Hamacher]

I can confirm both the reporter's 'hang' and Andrew's solution from comment #1
(Linux current CVS build).

I believe the 'hang' is only perceived as a bug since the window stays empty -
if there were content in the window that would allow me to actually download
additional dictionaries as it is supposed to (and, perhaps, even showed a hint
after upgrading that I had to close the window first) there wouldn't be a problem.

@reporter:
Is this bug on the fact that the browser window stays empty (there *have* to be
duplicates on this), or on the fact that mozilla blocks until this empty window
is closed? Would you still percieve this as a bug if there was a hint in the
window that pointed out the fact that you had to close this window after the
installation of the additional dictionaries?

Comment 3

[Mike Kaply [:mkaply]]

We need to change download more to not open a modal browser window.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

This patch makes the new browser window non modal.

It also makes the dropdown flip back to the default dictionary rather than
staying on Download More

Comment 5

[Malte Rücker (mbr)]

*** Bug 221230 has been marked as a duplicate of this bug. ***

Comment 6

[Malte Rücker (mbr)]

*** Bug 218120 has been marked as a duplicate of this bug. ***

Comment 7

[Matthijs Wensveen]

bug 218120 was on the fact that the window stays empty. So is this really a
duplicate? There was no answer to comment #2's @reporter...
I agree that bug 221230 is a dupe.

Comment 8

[Daniel Küstner]

Sorry for not answering. This bug was on the fact that mozilla blocks. I didn't
answer, because I assume, the proposed patch fixes exactly this.

Comment 9

[Mike Kaply [:mkaply]]

There are two bugs here, the blocking and the blank url.

We are working on where the URL should go.

Comment 10

[Greg Trounson]

Confirmed with Mozilla 1.5 [Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5)
Gecko/20031007]

Two issues as I see it:
1. Window is empty. (bigger of the 2 issues, IMO)
2. Window is modal.

No. 2 could be considered a design feature, but No.1 is definitely a bug.

Comment 11

[Victor Bajanov]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5)
Gecko/20031007 (Mozilla 1.5 on Windows XP SP1)

Other mozilla windows don't become non-responsive - I can still browse normally
in  other windows. 

The modal window opens at the default window size for mozilla windows which for
me is maximised - thus _hiding_ the email composition and spell checker windows.
Also it doesn't create a separate entry on the taskbar, so clicking on the
message composition window's taskbar entry bring up the empty browser window.
It's difficult to find the message composition window without un-maximising the
empty browser that pops up but even then it's unusable (won't focus, when you
attempt to switch to it, the modal browser window blinks a few times the way a
dialog box would). I guess this is all just hand in hand with the window being
modal so isn't news to anyone, I just thought I'd mention it as the description
up till now (mozilla unusable until window closed) seemed a little harsh. 

The real issue at hand is that selecting the 'Download More' option does not
actually lead to the downloading of new dictionaries nor even hint at where such
dictionaries might be obtained. Whether the browser window is modal or not is
moot if all it does is sit there - it should be browsing to a selection of
additional language packs. 

Comment 12

[Hermann Schwab]

wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031118
details see bug 226102 comment #2

has anybody retried downloading more languages using a Mozilla 1.6a or newer?

Comment 13

[Jo Hermans]

Yes, it works for me in build 2003111803 on Mac OS X 10.2.8 :
http://dictionaries.mozdev.org/installation.html opened in a new window. I tried
downloading Dutch.

Comment 14

[Christian Hamacher]

Same here: WFM on yesterday's trunk CVS build on Linux.

Has the patch from comment #4 been checked into the trunk? If yes, I missed it ...

But this seems FIXED/WFM anyway.

Comment 15

[Christian Hamacher]

Sorry for the spam ... :-(

I just realized that the main topic of this bug is the fact that mozilla seems
to freeze while the window opened for the update is still open (since it is modal).

This problem is still present in my build.

The fact that this modal window remained empty was just a side issue, and the
topic of another bug.

Therefore, please ignore the "seems FIXED/WFM" part of comment #14

Comment 16

[Mike Kaply [:mkaply]]

This is fixed.

The fact that the window is blank is a separate issue for a separate bug.

Comment 17

[[e-mail]]

"Download More" should probably be some linked text in the way "Get More Themes"
is in the Themes pref panel.