217951 - instruction count reset during a call bytecode

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Ming-Yee Iu]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: 

In org.mozilla.javascript.Interpreter.interpret(...), the instruction count 
gets reset during the processing of Token.CALL bytecodes. I'm not sure if this 
behavior is intentional, but it differs from the behavior of the 
Icode_CALLSPECIAL bytecode. 

In any case, I think the solution is to remove line 2322:

   cx.instructionCount = instructionCount;

which does not appear in the handler for the similar Icode_CALLSPECIAL bytecode.

Reproducible: Always

Steps to Reproduce:
1. Create a Context that observes the instruction counts
2. run some Javascript code in an infinite loop that calls a function

Actual Results:  
Context.observeInstructionCount() never gets called


Expected Results:  
Context.observeInstructionCount() should get called occasionally

Comment 1

[Igor Bukanov]

Attachment: Fix: removing instruction counter reset as suggested.

Comment 2

[Igor Bukanov]

I committed the fix.

Comment 3

[Phil Schwartau]

Rubber-stamp vrfy -

Comment 4

[Igor Bukanov]

Trageting as resolved against 1.5R5