Closed
Bug 217971
Opened 21 years ago
Closed 21 years ago
kEventHandlerMap in nsXULElement.cpp doesn't need to store iid pointers
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: keeda, Assigned: keeda)
Details
Attachments
(1 file)
|
6.55 KB,
patch
|
bryner
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
http://lxr.mozilla.org/seamonkey/source/content/xul/content/src/nsXULElement.cpp#1818
This is the only place that GetEventHandlerIID() is ever called in
nsXULElement.cpp. Looks like the code there is never using the iid pointer. It
only needs a |bool IsEventHandler(nsIAtom*)| thing.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 130724 [details] [diff] [review]
Get rid of all the unused data and make things a bit faster
bryner r+sr ?
Attachment #130724 -
Flags: review?(bryner)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 130724 [details] [diff] [review]
Get rid of all the unused data and make things a bit faster
Looks good, r+sr=me.
Attachment #130724 -
Flags: superreview+
Attachment #130724 -
Flags: review?(bryner)
Attachment #130724 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•