218021 - nsIPromptService::ConfirmCheck doesn't set checkValue, if Cancel

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Execute:
  var checkObj = {value: false};
  var answer = GetPromptService().confirmCheck(window,
                                       "Title", "Text", "Checkbox",
                                       checkObj);
  dump("checkbox state: " + (checkObj.value ? "on" : "off") + "\n");
2. Check checkbox, press Cancel

Actual result:
checkbox state: off

Expected result:
checkbox state: on

Fix:
embedding/components/windowwatcher/src/nsPromptService.cpp - ConfirmCheck():
-  if (*_retval) {
     block->GetInt(eCheckboxState, & tempInt);
     *checkValue = PRBool( tempInt );
-  }

Comment 1

[Ben Bucksch (:BenB)]

This is important for "Remember this decision" kind of dialogs - you'll want to
remember the declination as well.

Comment 2

[Adam Lock]

Attachment: Patch

The same patch as an attachment

Comment 3

[Adam Lock]

Comment on attachment 131573 [details] [diff] [review]
Patch

r=adamlock

Requesting sr on this no-brainer

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131573 [details] [diff] [review]
Patch

sr=bzbarsky if those lines are also outdented to the right level.

Comment 5

[Adam Lock]

Fix checked in