218203 - Crash when trying to show prompt from onunload

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.5b) Gecko/20030825

The attached testcase tries to show an alert in onUnload. However, in epiphany,
galeon and TestGtkEmbed it crashes instead in
GtkPromptService::GetGtkWindowForDOMWindow() on this line:

siteWindow->GetSiteWindow((void**)&parentWidget);

because siteWindow is null.

Note that this is not the same bug as bug 211834 .


Reproducible: Always

Steps to Reproduce:
1) Load attached test case.
2) Close browser window or tab.

Actual Results:  
Crash.


Expected Results:  
onunload alert is shown.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: Testcase

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed fix

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 130847 [details] [diff] [review]
proposed fix

This is an important issue for embed. The patch is a simple NULL check that
fixes a crasher, so I think there's no risk at all.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 130847 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to Mozilla 1.5

Comment 5

[[e-mail]]

Fix checked in.