218210 - find nodes does not work when searching for attribute

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Jochen Mader]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

when using the "find nodes" dialog in DOM Inspector to find a node by attribute
name + value, the "Find" button appears to do nothing.

However, the JavaScript Console displays an error: 
Error: aWalker.currentNode.getAttribute is not a function
Source File: chrome://inspector/content/viewers/dom/dom.js
Line: 560

B.T.W, already at DOM Inspector startup, the JavaScript Console displays:
Error: uncaught exception: [Exception... "Invalid ClassID or ContractID" 
nsresult: "0x80570017 (NS_ERROR_XPC_BAD_CID)"  location: "JS frame ::
chrome://inspector/content/jsutil/system/file.js :: <TOP_LEVEL> :: line 119" 
data: no]

Reproducible: Always

Steps to Reproduce:
1. Open JavaScript Console
2. Open DOM Inspector
3. Load any URL
4. Open "Find Nodes" dialog (Search -> Find Nodes...)
5. Select Search by Attr
6. Enter some attribute name + value
7. Click "Find"

Actual Results:  
Nothing visible in DOM Inspector, but JavaScript Console displays error.

Expected Results:  
Show a matching node, or tell me there is no matching node.

Comment 1

[Jochen Mader]

Can be fixed by inserting a pair of ():
Change

  doFindElementsByAttr: function(aWalker)
  {
    return aWalker.currentNode 
           && aWalker.currentNode.nodeType == Node.ELEMENT_NODE
           && this.mFindParams[1] == ""
              ? aWalker.currentNode.hasAttribute(this.mFindParams[0])
              : aWalker.currentNode.getAttribute(this.mFindParams[0]) ==
this.mFindParams[1];
  },

to

  doFindElementsByAttr: function(aWalker)
  {
    return aWalker.currentNode 
           && aWalker.currentNode.nodeType == Node.ELEMENT_NODE
           && (this.mFindParams[1] == ""
              ? aWalker.currentNode.hasAttribute(this.mFindParams[0])
              : aWalker.currentNode.getAttribute(this.mFindParams[0]) ==
this.mFindParams[1]);
  },

in dom.js (inspector.jar).

However, I propose that either this function is changed to test for substring
instead of equality or (better) that the Find Nodes dialog is extended so that
one can optionally search for substrings - especially when searching for attributes.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass re-assigning bugs to [e-mail]

Comment 3

[Daniel Brooks [:db48x]]

*** Bug 233202 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Brooks [:db48x]]

Attachment: fix

needs (), just like Jochen said.

Comment 5

[Daniel Brooks [:db48x]]

Attachment: fix, also make searches case insensitive and match against substrings

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141183 [details] [diff] [review]
fix, also make searches case insensitive and match against substrings

Please do not make id matches case-insensitive.   In fact, don't make the other
matches case-insensitive either, for XML documents.  Other than that,
sr=bzbarsky.

Comment 7

[Daniel Brooks [:db48x]]

Do you mind if I ask why? This is a convenience feature, not something that has
to meet a w3c spec. Plus I think it'd be inconvenient to find out what kind of
document we're searching, and also rather inconvenient for it to be
case-sensitive sometimes but not others.

Comment 8

[Daniel Brooks [:db48x]]

fix checked in