218248 - nsSingleSignonPrompt.h has CR/LF line terminations and it should not

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[lidl]

User-Agent:       Mozilla/5.0 (X11; U; BSD/OS i386; en-US; rv:1.5b) Gecko/20030903 Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (X11; U; BSD/OS i386; en-US; rv:1.5b) Gecko/20030903 Firebird/0.6.1+

The file mozilla/toolkit/components/passwordmgr/base/nsSingleSignonPrompt.h has
CR/LF endings, rather than just the LF, like most the rest of the sources in the
CVS archive.  This causes complilation problems on lines that end with \
(backslash) as the continuation character must be the last on the line...

I'm marking this as All/All, as it's a problem with the source code, regardless
of the platform.  That it happens to compile on Windows machines is a fluke, I
think.


Reproducible: Always

Steps to Reproduce:
1. examine the file with an editor that shows CR at the end of the line (like nvi)
2. Remove the ctrl-M characters from the file...
3. Notice that it then compiles.

Comment 1

[Brian Ryner (not reading)]

fixed (for nsSingleSignonPrompt.cpp as well)

Comment 2

[Simon Paquet [:sipaq]]

verified