218312 - OS/2 drag/drop & copy/paste updates

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Rich Walsh]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5b) Gecko/20030813
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5b) Gecko/20030813

The attached patch offers some minor changes for OS/2:

- Mouse copy/paste has been revised to more nearly emulate native
  behavior.  It now uses mouse movement rather than button-press
  order when deciding whether to copy or paste.

- Drags from Mozilla have been given more informative icons.
  Urls display the standard WPS Url icon while text uses a
  fairly generic textfile icon.  Mozilla-only drags continue
  to use the system file icon.

- Per the comment on Bugzilla #216920, nsWindow::ReleaseDragHPS
  has been reworked and renamed ReleaseIfDragHPS.

Files affected:

  Makefile.in
  nsDragService.cpp
  nsWindow.h
  nsWindow.cpp
  resource.h
  widget.rc
  res/dndtext.ico [new]
  res/dndurl.ico [new]


Reproducible: Always

Steps to Reproduce:

Comment 1

[Rich Walsh]

Attachment: diff showing changes to nsDragService, nsWindow, etc.

Comment 2

[Rich Walsh]

Attachment: zip containing dndurl.ico & dndtext.ico

Comment 3

[Boris Zbarsky [:bzbarsky]]

Over to someone who knows something about OS/2 and is (unlike Blake) working on
Mozilla.

Comment 4

[jhp (no longer active)]

>  	test -f ./res/aliasb.ptr || cp $(srcdir)/res/*.ptr ./res
> +	test -f ./res/dndurl.ico || cp $(srcdir)/res/*.ico ./res

The first line is just a simple hack to keep from trying to copy the PTRs over
themselves when building in the source tree.  So rather than duplicating the
hack, it might be best to just do this:

> -	test -f ./res/aliasb.ptr || cp $(srcdir)/res/*.ptr ./res
> +	test -f ./res/aliasb.ptr || cp $(srcdir)/res/*.* ./res

> +extern "C" {
> +  APIRET APIENTRY  DosQueryModFromEIP(HMODULE *phMod, ULONG *pObjNum,
> +                                      ULONG BuffLen,  PCHAR pBuff,
> +                                      ULONG *pOffset, ULONG Address);
> +}

This is also declared in nsWindow.cpp.  Just get rid of both references in the
CPP files and add it to nsWidgetDefs.h.

Otherwise, it looks good to me.  Still, mkaply should take a look at it, too.

Comment 5

[Rich Walsh]

Attachment: revised diff per comment #4

Comment 6

[jhp (no longer active)]

Comment on attachment 131050 [details] [diff] [review]
revised diff per comment #4

We need to get this checked in.  Kaply, take a look and check it in.

Comment 7

[Mike Kaply [:mkaply]]

Fix checked in.