218551 - Mozilla does not compile with gcc 3.4 cvs build (pedantic semicolon problem)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Brian Ryner (not reading)]

In cvs versions of gcc (what will be 3.4), extra semicolons at the top level are
now rejected as errors.  I have a patch which removes all of these that I could
find (a lot of these were scripted search-and-replace).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

I'll just call out the non-trivial parts of the patch:

I fixed the ctl makefile to make sure dist/lib is first in the library path. 
Otherwise, you get link warnings if you have an older libxpcom in /usr/lib.

In a couple of places in mailnews, I had to replace a static_cast of a
nsFileSpec to an nsFilePath with explicit construction of a nsFilePath from the
nsFileSpec.  I believe this is what was happening anyway, since there is no
other relationship between the two classes.

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 131018 [details] [diff] [review]
patch

dbaron, can you r/sr or rubber-stamp me?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... this is a duplicate of bug 217265... but both bugs have patches.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

> In a couple of places in mailnews, I had to replace a static_cast of a
> nsFileSpec to an nsFilePath with explicit construction of a nsFilePath from the
> nsFileSpec.  I believe this is what was happening anyway, since there is no
> other relationship between the two classes.

What error did gcc give there?

r+sr=dbaron (mostly rubber-stamp) on the whole thing (I think the construction
is clearer, but I think the static cast should work)

I think it would be good to get this in for 1.5 to reduce the compilation bugs
we get about it.

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 131018 [details] [diff] [review]
patch

Agreed, let's get this in for 1.5final.

/be

Comment 6

[Brian Ryner (not reading)]

I really did search for a dup, but forgot to search on unconfirmed bugs.

The error given without the nsFilePath patch is:

nsNewsFolder.cpp: In member function `nsresult
nsMsgNewsFolder::AddDirectorySeparator(nsFileSpec&)':
nsNewsFolder.cpp:319: error: invalid use of void expression

The error message seems kind of bogus to me.

Comment 7

[Matthias Versen [:Matti]]

*** Bug 217265 has been marked as a duplicate of this bug. ***

Comment 8

[Brian Ryner (not reading)]

checked in

Comment 9

[John Levon]

For reference: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12479

This gcc problem still causes build problems - Red Hat Linux 8.0
system headers have this problem.