218584 - about:config uses nsHttpChannel::Open

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

note:this is a _very_ special 1.4 branch build. need to verify on trunk (though
I don't think httpchannel::open asserts there)

for some reason, about:config tries to use nsHttpChannel::Open several times
that might be rather bad once that function gets implemented

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, this sucks...
about:config tries to interpret each preference value as a localized pref (if it
has no user-set value):
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/config.js#284

Getting a localized pref means that a stringbundle will be loaded from the given
url (or at least, that is attempted)

This uses ::Open on the channel created from the url, and then loads that url.
So - when bug 192284 is fixed, about:config will try to load all throbber urls,
among probably other things (home page e.g.)

I suppose a check if the url starts with chrome: would be a good idea before
trying to interpret the pref as localized pref

Comment 2

[[e-mail]]

Attachment: Proposed patch

This might also speed about:config up a bit.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

-> neil

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131081 [details] [diff] [review]
Proposed patch

r/sr=bzbarsky (pick one)

Comment 5

[Darin Fisher]

Comment on attachment 131081 [details] [diff] [review]
Proposed patch

r/sr=darin

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[Jesse Ruderman]

*** Bug 234006 has been marked as a duplicate of this bug. ***