218671 - If ipcThreadInit fails to create ipcThread then ipcTrans and ipcMonitor will leak

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[timeless]

static PRStatus
ipcThreadInit(ipcTransport *transport)
{
...
    NS_ADDREF(ipcTrans = transport); // <- can leak
    ipcShutdown = PR_FALSE;

    ipcMonitor = PR_NewMonitor(); // <- can leak
    if (!ipcMonitor)
        return PR_FAILURE; // <- leaks ipcTrans

    // spawn message thread
    ipcThread = PR_CreateThread(PR_USER_THREAD, ipcThreadFunc, NULL,
                                PR_PRIORITY_NORMAL, PR_GLOBAL_THREAD,
                                PR_JOINABLE_THREAD, 0);
    if (!ipcThread) {
        NS_WARNING("thread creation failed");
        return PR_FAILURE; // <- leaks ipcTrans and ipcMonitor
    }
...

ipcTransport::Disconnect()
{
    mHaveConnection = PR_FALSE;

    if (ipcThread) // <- guard which is only reached
// after both assignments and an additional alloc
        ipcThreadShutdown();
...

static PRStatus
ipcThreadShutdown()
{
    if (PR_AtomicSet(&ipcShutdown, PR_TRUE) == PR_FALSE) {
        LOG(("posting IPC_WM_SHUTDOWN message\n"));
        PostMessage(ipcLocalHwnd, IPC_WM_SHUTDOWN, 0, 0);
    }

    LOG(("joining w/ message thread...\n"));
    PR_JoinThread(ipcThread);
    ipcThread = NULL;

    //
    // ok, now the message thread is dead
    //

    PR_DestroyMonitor(ipcMonitor); // <- unreachable release unless ipcThread
    ipcMonitor = NULL;

    NS_RELEASE(ipcTrans); // <- unreachable release unless ipcThread and ipcMonitor

Comment 1

[timeless]

Attachment: try to avoid leaking

Comment 2

[Darin Fisher]

Comment on attachment 131094 [details] [diff] [review]
try to avoid leaking

looks right, thanks timeless.  r+sr=darin

Comment 3

[timeless]

bonsai indicates i checked this in