218685 - Liveconnect bug in ns4xPlugin.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[jhp (no longer active)]

From Innotek:

While investigating the liveconnect problem I have noticed another bug in
Mozilla OS2 code located in ns4xPlugin::ns4xPlugin and ns4xPlugin::CreatePlugin
in modules/plugin/base/src/ns4xPlugin.cpp

Flash plugin expects that the pointer to the  NPPluginFuncs structure passed as
parameter for NP_GetEntryPoints plugin function will not change in future. The
pointer is saved by plugin and accessed later at various places.
NS4.x does not change the pointer as well.

OS2 code initializes a local copy of the structure on stack and then
copies it to the class member.

So, the abovementioned functions should initialize fCallbacks structure like
Windows code does, that is pass the class member address to the
NP_GetEntryPoints. (see ns4xPlugin::ns4xPlugin #if defined(XP_WIN) branch)

Changes in ns4xPlugin.cpp may be:
line 303: #if defined(XP_WIN) || defined (XP_OS2)

lines 544-562: all removed (commented out)

line 564:  *aResult = new ns4xPlugin(nsnull, aLibrary, nsnull, aServiceMgr);

Comment 1

[jhp (no longer active)]

reassign to myself

Comment 2

[Mike Kaply [:mkaply]]

Javier, could you put a diff in here?

Comment 3

[Mike Kaply [:mkaply]]

Javier - post a freaking diff!

Comment 4

[Mike Kaply [:mkaply]]

Javier:

Hey loser boy. How about a patch?

Comment 5

[jhp (no longer active)]

Attachment: patch

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 135448 [details] [diff] [review]
patch

r=mkaply, sr=blizzard (platform specific) a=mkaply for 1.6b

Comment 7

[Mike Kaply [:mkaply]]

Fix checked in to branch and trunk.