Closed
Bug 218754
Opened 22 years ago
Closed 22 years ago
Don't double init nsPrefLocalizedString::mUnicodeString
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
810 bytes,
patch
|
benjamin
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
If you do:
Components.classes["@mozilla.org/pref-localizedstring;1"].createInstance()
You will hit:
nsPrefLocalizedString::Init()
nsPrefLocalizedStringConstructor(nsISupports * 0x00000000, const nsID & {...},
void * * 0x0012e080)
nsGenericFactory::CreateInstance(nsGenericFactory * const 0x00925460,
nsISupports * 0x00000000, const nsID & {...}, void * * 0x0012e080)
Which means that nsPrefLocalizedString::nsPrefLocalizedString doesn't need to do
any work.
Attachment #131132 -
Flags: superreview?(alecf)
Attachment #131132 -
Flags: review?(alecf)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 131132 [details] [diff] [review]
code savings :)
sr=alecf
Attachment #131132 -
Flags: superreview?(alecf) → superreview+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 131132 [details] [diff] [review]
code savings :)
since alecf gave sr, I think I can give r=
Attachment #131132 -
Flags: review?(alecf) → review+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•