218756 - Update to latest DOM Level 3 XPath specification

Status: RESOLVED FIXED

(Core :: XSLT, defect, P3)

Description

[Peter Van der Beken [:peterv]]

Error numbers changed and code on XPathException became writeable, I have a
patch for that. Other changes is that the evaluate methods on XPathExpression
and XPathEvaluator now take and return a DOMObject instead of a XPathResult.
Note that there seems to be an error in the exception definitions in DOM Level 3
specs, they remove "readonly attribute" from code, but that makes it invalid idl
(still need the "attribute").

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Axel Hecht]

Comment on attachment 131142 [details] [diff] [review]
v1

I take it that there is more work coming up?
r=[e-mail] for error codes and exception on no resolver.

Of course,
+    mResolver->LookupNamespaceURI(prefix, ns);
+    NS_ENSURE_SUCCESS(rv, rv);
indicates that you should actually assign the return value of
LookupNamespaceURI to rv.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 131142 [details] [diff] [review]
v1

sr=jst

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v2

Actually, I can roll in the DOMObject chang, it's easier than I thought.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 131145 [details] [diff] [review]
v2

Sorry about the earlier (premature as it turns out) r/sr request.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 131145 [details] [diff] [review]
v2

sr=jst

Comment 7

[Axel Hecht]

Comment on attachment 131145 [details] [diff] [review]
v2

r=[e-mail]

Comment 8

[Peter Van der Beken [:peterv]]

Checked in.

Comment 9

[Peter Van der Beken [:peterv]]

Reopening, I missed a spot :-/.

Comment 10

[Peter Van der Beken [:peterv]]

Attachment: Additional patch

Comment 11

[Axel Hecht]

Comment on attachment 132739 [details] [diff] [review]
Additional patch

oh, that's why I wasn't sure if this thing landed or not. As I found the old
error codes recently.

r=[e-mail]

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132739 [details] [diff] [review]
Additional patch

sr=bzbarsky

Comment 13

[Peter Van der Beken [:peterv]]

Fixed. Really.