Closed Bug 218775 Opened 22 years ago Closed 22 years ago

double-clicking an extension should show its options

Categories

(Firefox :: Settings UI, enhancement)

Product:
Firefox
Component:
Settings UI
Platform:
x86
Windows XP
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firebird0.8

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(2 files)

patch for reviewing (diff -u -w)
1.98 KB, patch
Details | Diff | Splinter Review
patch for checkin, including whitespace cleanup (diff -u)
3.30 KB, patch
Details | Diff | Splinter Review
In Tools-Options-Extensions, double-clicking an extension should open its options, because it's faster. In Tools-Options-Themes, double-clicking a theme should switch to that theme.
Risk with the theme switching is that it happens on closing the Options dialog. Would this mean new behaviour or close the dialog? Either way it could present problems. For the extensions, I think this is a good idea.
Let's start with the extensions. Reducing summary to that.
Summary: double-clicking an extension should open its options; double-clicking a theme should switch to that → double-clicking an extension should show its options
ondblclick, it first checks if the click is on an extension and not just somewhere on the white space below. If true, it calls a new function onDoubleClick. If the Options button is enabled, it shows the options.
This patch includes some whitespace cleanup (removing a few spaces). Check in this one, if you like it. Check in the other one, if you don't. :)
Comment on attachment 134824 [details] [diff] [review] patch for reviewing (diff -u -w) Pierre, here's another good-morning-patch. :) Use the other (diff -u -w) patch for checkin if you like it.
Attachment #134824 - Flags: review?(p_ch)
taking.
Assignee: blake → steffen.wilberg
Blocks: 225791
Target Milestone: --- → Firebird1.0
Comment on attachment 134824 [details] [diff] [review] patch for reviewing (diff -u -w) Moving review request from pch to Ben. Use the other (diff -u -w) patch for checkin if you like it.
Attachment #134824 - Flags: review?(p_ch) → review?(bugs)
This would be nice for 0.8.
Target Milestone: Firebird1.0 → Firebird0.8
Patch checked in. Thanks Steffen!
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment on attachment 134824 [details] [diff] [review] patch for reviewing (diff -u -w) Removing obsolete r? (Ben checked in the 'diff -u' patch on 12/15/2003 17:06).
Attachment #134824 - Flags: review?(bugs)
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: