218938 - document.lastModified returns current time for local file

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[HARUNAGA Hirotoshi]

document.lastModified returns the current time for a local file on
Mozilla 1.4b or later.
This is introduced by Bug 116598.

Steps:
1. Make html file like as follows.
<script type="text/javascript">
<!--
document.write(document.lastModified);
// -->
</script>

2. Open the local file.

Actual:
document.lastModified returns the current time.

Expected:
document.lastModified should return the last modified time like as IE
and NN 4.x.

Related to Bug 36681.

Comment 1

[Boris Zbarsky [:bzbarsky]]

+  if (mLastModified.IsEmpty()) {
+    modDate = PR_Now();
+  }

This should be done if modDate == LL_ZERO, not if mLastModified.IsEmpty() (which
it always is), no?

Comment 2

[Harshal Pradhan]

Attachment: Fix

mLastModified will not be empty if the channel was a http channel and it had a
last modified header. I think this is the correct fix.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131326 [details] [diff] [review]
Fix

sr=bzbarsky

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 131326 [details] [diff] [review]
Fix

r/sr=jst, duh! :-)

Comment 5

[Harshal Pradhan]

Taking

Comment 6

[Harshal Pradhan]

Checked in.