218997 - attachment folder setting not remembered

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[tironsi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

The setting of the default attachment folder is not remembered. I like to save
all my attachments in one directory and scan them regularly. There is a setting
in the options menu to do this, but it is not remembered. Instead, it defaults
to "Ask me where to save every attachment"

I am using: Mozilla Thunderbird 0.2 (20030901)

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Scott MacGregor]

this is listed in the release notes. I think I already have a bug filed to fix
this. 

Comment 2

[tironsi]

I couldn't find the bug through searching, then again I can never find anything
with that search. Sorry, should have looked at the release notes.

Comment 3

[tironsi]

Actually, I can't seem to find a mention of this issue at:
http://www.mozilla.org/projects/thunderbird/release-notes.html#issues

Comment 4

[Scott MacGregor]

I've tracked the problem down to this:

savePageData in nsWidgetStateManager:

    if (!(aPageTag in this.dataManager.pageData))
      return;

when we save the page for pref-downloads.xul, the data manager says that page
tag is not in our set and we bail out early.

I don't know why this scenario is happening though.

Comment 5

[Malte Rücker (mbr)]

*** Bug 228258 has been marked as a duplicate of this bug. ***

Comment 6

[Malte Rücker (mbr)]

Attachment: the fix that took a bit long

One space caused this bug ^_^ , take a look at the patch to find it.
And then there's a function call in pref-downloads.js (startup) that results in
a JS error in Thunderbird (but not in Firebird) which prevents that the page
data is saved and written to the prefs. doh!

Comment 7

[Scott MacGregor]

wow...you have to be kidding me....

the trailing space:

pref-downloads.xul "

caused the problem. Wow. Thanks mbr.....you have no idea how many hours I spent
deep in the bowels of the prefs system trying to debug this.

Comment 8

[Mickey Stein]

Speaking of white spaces (they're spreading!), is it just my copy or did 2 extra
whitespaces creep into pref-downloads.js after the 2nd #ifdef MOZ_PHOENIX today?
I can't seem to verify it after I got rid of them because the file seems to have
been checked back in yet again, but isn't showing as checked in yet. 

Comment 9

[Scott MacGregor]

checked in