219095 - filter/make bug....

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Doug Turner (:dougt)]

I am not sure if this is a mozilla specific bug or something in filter or make.

The problem is that if you have the follow in a Makefile:

FOO = $(filter stuff,$(BAR))

where the right hand side evaluates to an empty string, FOO is still defined.

A real example in mozilla is: mozilla/network/build2/Makefile.in.  

This is a windows only problem.  Any idea whose bug this is?

Comment 1

[cls]

It's a bug in the makefile.  The current make behavior is correct as there's a
difference between an expression that's evaluated to an empty string and a
variable not being defined (or a true empty string).  See
http://www.fsf.org/manual/make/html_chapter/make_7.html#SEC81 .

So for that specific case in netwerk/build2/Makefile.in, it should be using the
ifeq instead of ifdef.  I see the same behavior on linux using make 3.79.1 btw.

Comment 2

[cls]

Fix checked in.

Checking in netwerk/build2/Makefile.in;
/cvsroot/mozilla/netwerk/build2/Makefile.in,v  <--  Makefile.in
new revision: 1.25; previous revision: 1.24
done

Comment 3

[Doug Turner (:dougt)]

thanks chris!