219185 - checkin for bug 218874 probably broke IMAP mail

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Mitch]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030914
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030914

The checkin for bug 218874 appears to have broken IMAP mail.

Going to any IMAP server i have now fails with a popup saying

          "Mail server xxxxx is not an IMAP4 mail server"

Reverting to pre 218874 checkin and all works fine.

Reproducible: Always

Steps to Reproduce:
1. Connect to imap4 mailserver
2.
3.

Actual Results:  
see details.

Expected Results:  
obvious

Comment 1

[Mats Palmgren (inactive)]

Confirming bug, it works in 2003-09-13-05 and is broken 2003-09-13-22

Comment 2

[David :Bienvenu]

Is there anything special about your configuration?  Are you using SSL? Going
through a firewall? Using a proxy server? This works fine for most people, so
there must be something different about your configuration. Darin tried it on
Linux; I tried it on windows with SSL and non-SSL...

Comment 3

[Mitch]

Nope, nothing special. This in on a local UoW imap server (using localhost) with
Linux - i.e. no proxy, no firewall. But also fails with a SSL imap server - so
neither works. Both however use the host "localhost" since the SSL connection
is a tunnel on a different port.

Comment 4

[David :Bienvenu]

could you attach an imap protocol log? Do you have pre-auth setup?

http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

Comment 5

[David :Bienvenu]

localhost is somewhat special, but it does work for me, at least on windows,
with a UW server.

Comment 6

[Mats Palmgren (inactive)]

I'm using SSL, port 993, no (local) firewall, no proxy.

I have also had several hangs today with build 2003-09-13-22 on Linux.
This is a new problem as I have used current nightlies for quite some time
without seeing this problem.

Comment 7

[Mitch]

Nope no pre-auth setup. I guess i need to compile mozilla with --enable-logging
to get out logging messages. Recompiling now.

Comment 8

[David :Bienvenu]

did you explicitly disable logging? It's enabled by default.

Comment 9

[Mats Palmgren (inactive)]

Attachment: IMAP log

Comment 10

[Mats Palmgren (inactive)]

BTW, the hang is probably bug 219188 as I have a POP account too.

Comment 11

[Mitch]

Ok Mats beat me to it, but my log is exactly the same as his.

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: another imap log

My log is different.
This is imap from behind a linux firewall / nat router. I have the same problem
with imaps. Same log there. Log created with 2003091405 linux.

Comment 13

[David :Bienvenu]

this isn't in 1.5 so it can't block 1.5 - clearing

Comment 14

[Mats Palmgren (inactive)]

Attachment: Excerpts from the server log file

Comment 15

[David :Bienvenu]

Attachment: proposed fix

Comment 16

[David :Bienvenu]

Attachment: secondary fix

this fixes ReadNextLine to do the right thing as well.

Comment 17

[David :Bienvenu]

fix checked in; please try tomorrow's build, thx.

Comment 18

[Mitch]

Confirmed works with new checkout. Thanks David.

Comment 19

[David :Bienvenu]

great, thx, Mitch.  Again, sorry for the inconvenience.

Comment 20

[Mats Palmgren (inactive)]

Verified.  It works fine in 2003-09-14-22 trunk Linux.

Comment 21

[Scott MacGregor]

Just a comment for thunderbird 0.3 build contributors. You can safely apply both
the proposed and secondary patches to your tree. I'll be using both in my
official builds.