219217 - can't send data: url attachments

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[(not reading, please use [e-mail] instead)]

can't send data: url attachments

vCards will need this, as might that bug that mscott owns about sending BMP files.

but another bug that should be fixed by this:

1) find a page with a data url
2) dnd (or copy paste) the image into the compose window
3) send

before we fix this, we'd fail to send.

with this fix, we'll turn the data url into a mime part, as you'd expect.

Comment 1

[(not reading, please use [e-mail] instead)]

the fix:

Index: compose/src/nsMsgCompUtils.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgCompUtils.cpp,v
retrieving revision 1.156
diff -u -w -r1.156 nsMsgCompUtils.cpp
--- compose/src/nsMsgCompUtils.cpp	5 Sep 2003 17:49:00 -0000	1.156
+++ compose/src/nsMsgCompUtils.cpp	14 Sep 2003 21:53:51 -0000
@@ -1706,7 +1706,7 @@
   nsCOMPtr<nsIIOService> pNetService(do_GetService(kIOServiceCID, &rv)); 
   if (NS_SUCCEEDED(rv) && pNetService)
   {
-    if (PL_strstr(aSpec, "://") == nsnull)
+    if (PL_strstr(aSpec, "://") == nsnull && strncmp(aSpec, "data:", 5))
     {
       //XXXjag Temporary fix for bug 139362 until the real problem(bug 70083)
get fixed
       nsCAutoString uri(NS_LITERAL_CSTRING("http://") + nsDependentCString(aSpec));

Comment 2

[(not reading, please use [e-mail] instead)]

fixed.

mscott checked this in for me.

Comment 3

[[e-mail]]

Also this fix is neat for Composer's Send Page option,
it means that the page can be sent without saving it.