Closed
Bug 219230
Opened 21 years ago
Closed 21 years ago
winembed should use the simpliest profile solution - minimo
Categories
(Core Graveyard :: Embedding: Packaging, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
|
18.35 KB,
patch
|
adamlock
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #131477 -
Flags: review?(darin)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 131477 [details] [diff] [review]
patch v.1
adam lock should review this change since he added this code in the first
place.
Attachment #131477 -
Flags: review?(darin) → review?(adamlock)
|
|
Assignee | |
Comment 3•21 years ago
|
||
just for the record, winembed is currently dead and unsupported. I can take
ownership if needed.
Comment on attachment 131477 [details] [diff] [review]
patch v.1
r=adamlock
Winembed is currently comatose, but I think from its continual use that it
should deserve some attention, even if only as a tier 2 embedding app. Mfcembed
is too complicated and not very applicable for ongoing embedding work.
Re this patch, I don't see anything wrong with it, but we should switch
emphasis from winembed being a normal embedding sample, to being a minimal
embedding sample.
Attachment #131477 -
Flags: review?(adamlock) → review+
|
|
||
Comment 5•21 years ago
|
||
Comment on attachment 131477 [details] [diff] [review]
patch v.1
sr=darin
Attachment #131477 -
Flags: superreview+
|
|
Assignee | |
Comment 6•21 years ago
|
||
thanks.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•