219327 - mingw build fails with w32api 2.4

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[cls]

In the original mingw port (bug 134113), we added an ifdef to
nsRenderingContextWin.cpp to work around a discrepancy between MSVC's & Mingw's
implementations of the win32 api.  With w32api 2.4, that discrepancy has been
fixed so the ifdef should be removed and a hard check for 2.4 added.  (Or we
could modify the ifdef to allow w32api 2.3 to still work.)

Comment 1

[cls]

Attachment: v1.0

Comment 2

[David G King]

That would explain why my build has stopped working.

Comment 3

[David G King]

FYI, this patch fixes my compile problem when using w32api v2.4.

Comment 4

[cls]

*** Bug 219423 has been marked as a duplicate of this bug. ***

Comment 5

[cls]

Comment on attachment 131537 [details] [diff] [review]
v1.0

> bryner: any thoughts on bumping the mingw build requirements?
<bryner> cls: is this because of w32api changes?
> bryner: yes and the windres fix
<bryner> i'm fine with it

Comment 6

[cls]

Patch has been checked in.

Comment 7

[Steffen Wilberg]

Comment on attachment 131537 [details] [diff] [review]
v1.0

We should get this into the 1.5 branch as well. Should be low risk as it only
concerns MinGW, and it makes that work with the latest w32api.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 131537 [details] [diff] [review]
v1.0

too late for 1.5.