Closed Bug 219346 Opened 21 years ago Closed 21 years ago

DB error instead of formatted error page when user changes bug without proper rights

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED DUPLICATE of bug 218977

People

(Reporter: andreas.hoefler, Assigned: myk)

Details

Attachments

(1 file)

adds table 'namedqueries' to read-locked list
758 bytes, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a; MultiZilla v1.5.0.2Beta) Gecko/20030830
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a; MultiZilla v1.5.0.2Beta) Gecko/20030830

When entering a bug into a group where the reporter has no change-access (only
entry), a DB error shows up instead of a BZ error when the reporter tries to
commit a change to the bug on the "bug submitted"-page.

Reproducible: Always

Steps to Reproduce:
1. Enter a Bug into a group where you only have enter-rights
2. change something of the bug on the "Bug submitted"-confirmation page
3. commit

Actual Results:  
Bugzilla has suffered an internal error. Please save this page and send it to
andreas.hoefler@bearingpoint.com with details of what you were doing at the time
this message appeared. 

URL: http://verdi.techu.local/taskzilla/process_bug.cgi

Template->process() failed twice.
First error: undef error - DBD::mysql::st execute failed: Table 'namedqueries'
was not locked with LOCK TABLES [for Statement " SELECT name, query,
linkinfooter FROM namedqueries WHERE userid=? ORDER BY UPPER(name)"] at
Bugzilla/User.pm line 155
Bugzilla::User::queries('Bugzilla::User=HASH(0x86445cc)') called at
data/template/en/custom/global/useful-links.html.tmpl line 172 eval {...} called
at data/template/en/custom/global/useful-links.html.tmpl line 172 eval {...}
called at data/template/en/custom/global/useful-links.html.tmpl line 16
Template::Provider::__ANON__('Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line 141 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm
line 139 Template::Document::process('Template::Document=HASH(0x873fa1c)',
'Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320 Template::Context::process('Template::Context=HASH(0x85c562c)',
'global/useful-links.html.tmpl') called at
data/template/en/custom/global/footer.html.tmpl line 23 eval {...} called at
data/template/en/custom/global/footer.html.tmpl line 16
Template::Provider::__ANON__('Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line 141 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm
line 139 Template::Document::process('Template::Document=HASH(0x8730734)',
'Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320 Template::Context::process('Template::Context=HASH(0x85c562c)',
'global/footer.html.tmpl') called at
data/template/en/custom/global/user-error.html.tmpl line 1467 eval {...} called
at data/template/en/custom/global/user-error.html.tmpl line 16
Template::Provider::__ANON__('Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line 141 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm
line 139 Template::Document::process('Template::Document=HASH(0x86fb7b0)',
'Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320 Template::Context::process('Template::Context=HASH(0x85c562c)',
'Template::Document=HASH(0x86fb7b0)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Service.pm line 97 eval {...}
called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Service.pm line 94
Template::Service::process('Template::Service=HASH(0x85c269c)',
'global/user-error.html.tmpl', 'HASH(0x869aa8c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template.pm line 76
Template::process('Bugzilla::Template=HASH(0x85c1438)',
'global/user-error.html.tmpl', 'HASH(0x869aa8c)') called at Bugzilla/Error.pm
line 42 Bugzilla::Error::ThrowUserError('product_edit_denied',
'HASH(0x869aa8c)') called at /usr/local/httpd/htdocs/taskzilla/process_bug.cgi
line 1146 
Second error: undef error - DBD::mysql::st execute failed: Table 'namedqueries'
was not locked with LOCK TABLES [for Statement " SELECT name, query,
linkinfooter FROM namedqueries WHERE userid=? ORDER BY UPPER(name)"] at
Bugzilla/User.pm line 155
Bugzilla::User::queries('Bugzilla::User=HASH(0x86445cc)') called at
data/template/en/custom/global/useful-links.html.tmpl line 172 eval {...} called
at data/template/en/custom/global/useful-links.html.tmpl line 172 eval {...}
called at data/template/en/custom/global/useful-links.html.tmpl line 16
Template::Provider::__ANON__('Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line 141 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm
line 139 Template::Document::process('Template::Document=HASH(0x873fa1c)',
'Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320 Template::Context::process('Template::Context=HASH(0x85c562c)',
'global/useful-links.html.tmpl') called at
data/template/en/custom/global/footer.html.tmpl line 23 eval {...} called at
data/template/en/custom/global/footer.html.tmpl line 16
Template::Provider::__ANON__('Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line 141 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm
line 139 Template::Document::process('Template::Document=HASH(0x8730734)',
'Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320 Template::Context::process('Template::Context=HASH(0x85c562c)',
'global/footer.html.tmpl') called at
data/template/en/custom/global/code-error.html.tmpl line 837 eval {...} called
at data/template/en/custom/global/code-error.html.tmpl line 16
Template::Provider::__ANON__('Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line 141 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm
line 139 Template::Document::process('Template::Document=HASH(0x8788974)',
'Template::Context=HASH(0x85c562c)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340 eval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320 Template::Context::process('Template::Context=HASH(0x85c562c)',
'Template::Document=HASH(0x8788974)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Service.pm line 97 eval {...}
called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Service.pm line 94
Template::Service::process('Template::Service=HASH(0x85c269c)',
'global/code-error.html.tmpl', 'HASH(0x85c1564)') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template.pm line 76
Template::process('Bugzilla::Template=HASH(0x85c1438)',
'global/code-error.html.tmpl', 'HASH(0x85c1564)') called at CGI.pl line 294
main::ThrowTemplateError('undef error - DBD::mysql::st execute failed: Table
\'namedqueries\' was not locked with LOCK TABLES [for Statement " SELECT name,
query, linkinfooter^J FROM namedqueries^J WHERE userid=?^J ORDER BY
UPPER(name)"] at Bugzilla/User.pm line
155^J^IBugzilla::User::queries(\'Bugzilla::User=HASH(0x86445cc)\') called at
data/template/en/custom/global/useful-links.html.tmpl line 172^J^Ieval {...}
called at data/template/en/custom/global/useful-links.html.tmpl line 172^J^Ieval
{...} called at data/template/en/custom/global/useful-links.html.tmpl line
16^J^ITemplate::Provider::__ANON__(\'Template::Context=HASH(0x85c562c)\') called
at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line
141^J^Ieval {...} called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line
139^J^ITemplate::Document::process(\'Template::Document=HASH(0x873fa1c)\',
\'Template::Context=HASH(0x85c562c)\') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340^J^Ieval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320^J^ITemplate::Context::process(\'Template::Context=HASH(0x85c562c)\',
\'global/useful-links.html.tmpl\') called at
data/template/en/custom/global/footer.html.tmpl line 23^J^Ieval {...} called at
data/template/en/custom/global/footer.html.tmpl line
16^J^ITemplate::Provider::__ANON__(\'Template::Context=HASH(0x85c562c)\') called
at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line
141^J^Ieval {...} called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line
139^J^ITemplate::Document::process(\'Template::Document=HASH(0x8730734)\',
\'Template::Context=HASH(0x85c562c)\') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340^J^Ieval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320^J^ITemplate::Context::process(\'Template::Context=HASH(0x85c562c)\',
\'global/footer.html.tmpl\') called at
data/template/en/custom/global/user-error.html.tmpl line 1467^J^Ieval {...}
called at data/template/en/custom/global/user-error.html.tmpl line
16^J^ITemplate::Provider::__ANON__(\'Template::Context=HASH(0x85c562c)\') called
at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line
141^J^Ieval {...} called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Document.pm line
139^J^ITemplate::Document::process(\'Template::Document=HASH(0x86fb7b0)\',
\'Template::Context=HASH(0x85c562c)\') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm line 340^J^Ieval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Context.pm
line 320^J^ITemplate::Context::process(\'Template::Context=HASH(0x85c562c)\',
\'Template::Document=HASH(0x86fb7b0)\') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Service.pm line 97^J^Ieval
{...} called at /usr/lib/perl5/site_perl/5.6.1/i586-linux/Template/Service.pm
line 94^J^ITemplate::Service::process(\'Template::Service=HASH(0x85c269c)\',
\'global/user-error.html.tmpl\', \'HASH(0x869aa8c)\') called at
/usr/lib/perl5/site_perl/5.6.1/i586-linux/Template.pm line
76^J^ITemplate::process(\'Bugzilla::Template=HASH(0x85c1438)\',
\'global/user-error.html.tmpl\', \'HASH(0x869aa8c)\') called at
Bugzilla/Error.pm line
42^J^IBugzilla::Error::ThrowUserError(\'product_edit_denied\',
\'HASH(0x869aa8c)\') called at /usr/local/httpd/htdocs/taskzilla/process_bug.cgi
line 1146^J') called at Bugzilla/Error.pm line 42
Bugzilla::Error::ThrowUserError('product_edit_denied', 'HASH(0x869aa8c)') called
at /usr/local/httpd/htdocs/taskzilla/process_bug.cgi line 1146 


Expected Results:  
A proper formatted BZ-error page.

The group restrictions for the product are:
Entry: unchecked
Member Control: default
Other Control: default
Canedit: checked

The line which should show the proper BZ-Error (but currently causes the
DB-Error) is in process_bug.cgi at line 1145:
...
    if (!CanEditProductId($oldhash{'product_id'})) {
        ThrowUserError("product_edit_denied",
                      { product => $oldhash{'product'} });
    }
...
This adds the table 'namedqueries' to the list of locked tables as read-locked

*** This bug has been marked as a duplicate of 218977 ***
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: