Closed
Bug 219451
Opened 21 years ago
Closed 21 years ago
update localeVersion for 1.5
Categories
(Core :: Internationalization: Localization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
(Keywords: fixed1.5)
Attachments
(1 file)
70.73 KB,
patch
|
blizzard
:
review+
blizzard
:
superreview+
asa
:
approval1.5+
|
Details | Diff | Splinter Review |
Bug 154927 is still unfixed, though there may be light at the end of the tunnel, a way to fix it was suggested a few days ago, and one file actually flips the version already. Anyway, we still have to update all the others for the 1.5 release. I hope I'll come around to attach a patch soon.
Assignee | ||
Updated•21 years ago
|
Flags: blocking1.5?
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #131616 -
Flags: superreview?(blizzard)
Attachment #131616 -
Flags: review?(blizzard)
Attachment #131616 -
Flags: approval1.5?
Comment 2•21 years ago
|
||
Comment on attachment 131616 [details] [diff] [review] patch: flip localeVersion to 1.5 rubber-stamping with r+rs=blizzard
Attachment #131616 -
Flags: superreview?(blizzard)
Attachment #131616 -
Flags: superreview+
Attachment #131616 -
Flags: review?(blizzard)
Attachment #131616 -
Flags: review+
Updated•21 years ago
|
Flags: blocking1.5? → blocking1.5+
Comment 3•21 years ago
|
||
Comment on attachment 131616 [details] [diff] [review] patch: flip localeVersion to 1.5 a=asa (on behalf of drivers) for checkin to the Mozilla 1.5 branch. Please add the fixed1.5 keyword when this is landed on the branch. Thanks.
Attachment #131616 -
Flags: approval1.5? → approval1.5+
Assignee | ||
Comment 5•21 years ago
|
||
Patch checked in. I hope I have missed nothing...
Comment 6•21 years ago
|
||
Robert, I think you missed (US.jar/locale/US/global-region/region.dtd), entity content.version. The rest seems complete, but I'll wait for the next 1.5 nightly to confirm that based on the actual jar contents.
Comment 7•21 years ago
|
||
Robert, xpfe/global/resources/locale/en-US/region.dtd (see http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/resources/locale/en-US/region.dtd&rev=MOZILLA_1_5_BRANCH&root=/cvsroot) still indicates <!ENTITY content.version "1.5b"> rather than 1.5. Could you please fix it (or reopen this bug until it is fixed)?
Comment 8•21 years ago
|
||
Bonsai still shows a file with 1.5b references, the Linux nightly from 2003-09-23-17-1.5 has 1.5 only in this file, and the Windows nightly from 2003-09-23-12-1.5 has 1.5b in this file. So it's fixed in the Linux nightly, but not in the Windows or current CVS. Not sure how that end up to be...
Assignee | ||
Comment 9•21 years ago
|
||
Hmm, that's strange... What does milestone.txt have? region.dtd should pick up that one, as its handling was changed - see bug 154927 and http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/locale/en-US/region.dtd.in
You need to log in
before you can comment on or make changes to this bug.
Description
•