219487 - Make new DNS code build/run on OpenVMS

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Colin Blake]

The DNS rewrite (bug 205726) leaves NSPR not building on OpenVMS. In order to
get it to build I need to no longer define "struct addrinfo" in _openvms.h.

I also need to define the environment variables GETADDRINFO and FREEADDRINFO so
that the new code which does getenv() calls for these (only for OpenVMS) will work.

I'll post the patch next. Both files are OpenVMS specific and so shouldn't break
anyone else.

Comment 1

[Colin Blake]

Attachment: OpenVMS fix

Comment 2

[Colin Blake]

Requesting blocking1.6a status since I can't build on OpenVMS without this fix.

Comment 3

[Wan-Teh Chang]

Attachment: OpenVMS fix for Mozilla (by Colin Blake)

Comment 4

[Wan-Teh Chang]

Attachment: OpenVMS fix for NSPR (by wtc)

Comment 5

[Wan-Teh Chang]

Comment on attachment 131617 [details] [diff] [review]
OpenVMS fix for Mozilla (by Colin Blake)

Colin, NSPR may be using getnameinfo() in the near future.
Might be a good idea to add an environment variable for
getnameinfo() now.

Comment 6

[Wan-Teh Chang]

Comment on attachment 131618 [details] [diff] [review]
OpenVMS fix for NSPR (by wtc)

Colin,

Could you test this patch?

Could you verify that AI_CANONNAME is defined as 2
and struct addrinfo is defined as

 struct addrinfo {
     int ai_flags;
     int ai_family;
     int ai_socktype;
     int ai_protocol;
     size_t ai_addrlen;
     char *ai_canonname;
     struct sockaddr *ai_addr;
     struct addrinfo *ai_next;
 };

in OpenVMS's <netdb.h> header?

Thanks.

Comment 7

[Colin Blake]

> Could you verify that AI_CANONNAME is defined as 2
> and struct addrinfo is defined as...

Alrady checked them. Yes.

Comment 8

[Colin Blake]

Comment on attachment 131618 [details] [diff] [review]
OpenVMS fix for NSPR (by wtc)

Patch builds fine. I've also added getnameinfo to the env var list.

Comment 9

[Wan-Teh Chang]

Comment on attachment 131618 [details] [diff] [review]
OpenVMS fix for NSPR (by wtc)

Thank you, Colin.  I've checked in the NSPR patch on
the NSPR trunk (NSPR 4.5) and NSPRPUB_PRE_4_2_CLIENT_BRANCH
(Mozilla 1.6 alpha).

Comment 10

[Colin Blake]

Can we mark this resolved now its checked in?

Comment 11

[Wan-Teh Chang]

Colin,

I left this bug open for you to check in the patch
for mozilla/build/unix/vms/mozilla.com.  Have you
checked in that patch?

Comment 12

[Colin Blake]

Oh, OK. No, I haven't yet. I'm not even building 1.6 yet. I'll try to get to
this before I leave.

Comment 13

[Colin Blake]

Checked in the mozilla.com file to the Mozilla trunk. Rev 1.6.

Now can we close this :-)

Comment 14

[Wan-Teh Chang]

Marked the bug fixed.