219536 - nsWidget::InitEvent leaks events, and thus the main window

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsWidget::InitEvent leaks events, and thus the main window, since 
gtk_get_current_event returns a result that was copied and must be freed using
gdk_event_free.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: mozilla side of debugging code I used (I may want this again...)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: gdk side of debugging code I used (I may want this again...)

This wasn't perfect, but it was close enough.

Comment 4

[Christopher Blizzard (:blizzard)]

So copying the event prevents it from being leaked?  That seems odd.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No, it's always been copied.  We need to free the copy to prevent the window
from being leaked.  (The events themselves are arena-allocated.)

Comment 6

[Christopher Blizzard (:blizzard)]

Comment on attachment 131645 [details] [diff] [review]
patch

ahh, sorry.  I was mis-reading the patch.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-09-24 22:34:25 -0700.