219552 - Improve performance of RowCellColumnToCollationKey

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[[e-mail]]

I was doing some basic performance testing on sorting 10000+ messages by subject
(because that's how I read bugmail) and have in the past improved performance in
intl by optimizing AllocateRawSortKey but now I'm turning my attention further
up the chain :-) By inlining the code in RowCellColumnToCollationKey I was able
to avoid some steps and pass an nsAString directly to AllocateRawSortKey. This
appeared to speed up sorting by about 10%.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[David :Bienvenu]

-> Neil

Comment 3

[[e-mail]]

Fix checked in.

Comment 4

[[e-mail]]

Attachment: Fix null subject crash

What was happening for an empty subject was that ...ToMime2DecodedString just
returned early, and an empty collation key was created. Now when I inlined
...ToMime2DecodedString I copied the early return, unfortunately this means
that no collation key is created, therefore crash.

The fix is to copy code from ...ToAddressCollationKey which passes the string
to DecodeMimeHeader which will return early for an empty string anyway.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132166 [details] [diff] [review]
Fix null subject crash

sr=bzbarsky

Comment 6

[David :Bienvenu]

Comment on attachment 132166 [details] [diff] [review]
Fix null subject crash

r/sr=me