219573 - compile warning - unused variables in nsSelection.cpp

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Josh Aas]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030914 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030914 Camino/0.7+

In the file:

mozilla/content/base/src/nsSelection.cpp

there are several unused variables.

Reproducible: Always

Steps to Reproduce:
1. Compile Mozilla on Mac OS X with GCC 3.1
2.
3.

Actual Results:  
I get a warning about these 3 unused variables.

Expected Results:  
Not give a warning - not contain unused variables.

Comment 1

[Josh Aas]

Attachment: patch to get rid of unused variables

It should be OK to kill these variables.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Please use the -p switch to diff when making patches, and include more context
(3 lines is not enough to usefully review changes like this one, typically; 6-10
lines is better).

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131675 [details] [diff] [review]
patch to get rid of unused variables

sr=bzbarsky if those are actually unused.  I can check this in after the 23rd
(if you remind me); if you find someone to do it before then, great.  It needs
r= first, of course.

Comment 4

[Mike Kaply [:mkaply]]

Checked in by mkaply.