Closed
Bug 219608
Opened 21 years ago
Closed 21 years ago
compile warning in helperappservice
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
|
988 bytes,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
1. uriloader/exthandler/nsExternalHelperAppService.cpp:2232 (See build log excerpt)
Comparison between signed and unsigned integer expressions
2230 {
2231 // First of all, check our default entries
2232 for (PRIntn i = 0; i < NS_ARRAY_LENGTH(defaultMimeEntries); i++)
2233 {
2234 if (strcmp(defaultMimeEntries[i].mFileExtension, aFileExt) == 0) {
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #131797 -
Flags: review?(bz-vacation)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.6alpha
|
||
Comment 2•21 years ago
|
||
Comment on attachment 131797 [details] [diff] [review]
patch
r=bzbarsky
Attachment #131797 -
Flags: review?(bz-vacation) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #131797 -
Flags: superreview?(darin)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 131797 [details] [diff] [review]
patch
nit: wouldn't size_t make more sense? or should NS_ARRAY_LENGTH include a cast
to PRUintn?
sr=darin
Attachment #131797 -
Flags: superreview?(darin) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
checked in with size_t
Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v <--
nsExternalHelperAppService.cpp
new revision: 1.217; previous revision: 1.216
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•