219621 - sender column now at the end with a new profile

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Matthias Versen [:Matti]]

win2k build 20030918..

The sender column moved to the end of the pane after the fix for bug 36492.
It should stay in the old default position (also for old profiles)

Comment 1

[Ere Maijala (slow)]

Attachment: v1 Patch

Patch to UpgradeThreadPaneUI to move the new columns to the default positions.

Comment 2

[[e-mail]]

Comment on attachment 131722 [details] [diff] [review]
v1 Patch

Unless I've misread it (which is quite possible as the diff looks very ugly)
you're inserting the sender/recipient after the junk column before the existing
junk column fix, so someone upgrading from version 2 won't get the right fix.

Comment 3

[Ere Maijala (slow)]

Attachment: v1 Patch

Good point. This patch has the order fixed.

Comment 4

[Ere Maijala (slow)]

Attachment: Diff -uw for the patch which should be v2

Comment 5

[[e-mail]]

Comment on attachment 131729 [details] [diff] [review]
v1 Patch

>+    if (threadPaneUIVersion < 4) {
>+
>       var threadTree = document.getElementById("threadTree");
>+      var junkCol = document.getElementById("junkStatusCol");
>+
>+      if (threadPaneUIVersion < 3) {
>+
>+        var subjectCol = document.getElementById("subjectCol");
Too many blank lines. The middle one is ok but lose the other two.

Comment 6

[Ere Maijala (slow)]

Comment on attachment 131729 [details] [diff] [review]
v1 Patch

I'll remove the extra blanks before checking in.

Comment 7

[David :Bienvenu]

Comment on attachment 131734 [details] [diff] [review]
Diff -uw for the patch which should be v2

sr=bienvenu

Comment 8

[Ere Maijala (slow)]

Fix checked in.