219673 - Uninitialized memory read in nsHTMLEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Harshal Pradhan]

From purify:

[W] UMR: Uninitialized memory read in
nsHTMLEditor::MouseUp(int,int,nsIDOMElement *) {1 occurrence}
        Reading 1 byte from 0x106aae4e (1 byte at 0x106aae4e uninitialized)
        Address 0x106aae4e is 414 bytes into a 628 byte block at 0x106aacb0
        Address 0x106aae4e points to a C++ new block in heap 0x024f0000
        Thread ID: 0x7b8
        Error location
            nsHTMLEditor::MouseUp(int,int,nsIDOMElement *)
[nshtmlobjectresizer.cpp:646]
                    HideShadowAndInfo();
                    SetFinalSize(aClientX, aClientY);
                  }
             =>   else if (mIsMoving || mGrabberClicked) {
                    if (mIsMoving) {
                     
mPositioningShadow->SetAttribute(NS_LITERAL_STRING("class"),
NS_LITERAL_STRING("hidden"));
                      SetFinalPosition(aClientX, aClientY);
            nsHTMLEditorMouseListener::MouseUp(nsIDOMEvent *)
[nshtmleditormouselistener.cpp:106]
                    PRInt32 clientX, clientY;
                    mouseEvent->GetClientX(&clientX);
                    mouseEvent->GetClientY(&clientY);
             =>     objectResizer->MouseUp(clientX, clientY, element);
                  }
                
                  return nsTextEditorMouseListener::MouseUp(aMouseEvent);
            nsCOMPtr<nsIEditor>::nsCOMPtr<nsIEditor>(nsQueryInterface const&)
[nscomptr.h:549]
                
            nsUndoCommand::IsCommandEnabled(char const*,nsISupports *,int *)
[nseditorcommands.cpp:74]
                                                PRBool *outCmdEnabled)
                {



[W] UMR: Uninitialized memory read in
nsHTMLEditor::MouseUp(int,int,nsIDOMElement *) {1 occurrence}
        Reading 1 byte from 0x106aae4e (1 byte at 0x106aae4e uninitialized)
        Address 0x106aae4e is 414 bytes into a 628 byte block at 0x106aacb0
        Address 0x106aae4e points to a C++ new block in heap 0x024f0000
        Thread ID: 0x7b8
        Error location
            nsHTMLEditor::MouseUp(int,int,nsIDOMElement *)
[nshtmlobjectresizer.cpp:651]
                     
mPositioningShadow->SetAttribute(NS_LITERAL_STRING("class"),
NS_LITERAL_STRING("hidden"));
                      SetFinalPosition(aClientX, aClientY);
                    }
             =>     if (mGrabberClicked) {
                      EndMoving();
                      mGrabberClicked = PR_FALSE;
                      mIsMoving = PR_FALSE;
            nsHTMLEditorMouseListener::MouseUp(nsIDOMEvent *)
[nshtmleditormouselistener.cpp:106]
            nsWindow::DispatchEvent(nsGUIEvent *,nsEventStatus&) [nswindow.cpp:1050]
            nsWindow::DispatchWindowEvent(nsGUIEvent *) [nswindow.cpp:1070]

Comment 1

[Harshal Pradhan]

Oops ... fixing typo in summary.

Comment 2

[Harshal Pradhan]

Attachment: Fix ?

Comment 3

[Harshal Pradhan]

Comment on attachment 131723 [details] [diff] [review]
Fix ?

Daniel can you please have a look at this?

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 131723 [details] [diff] [review]
Fix ?

good catch. Thanks!
r=glazman
get a sr and check that in ASAP :-)

Comment 5

[Harshal Pradhan]

Taking ... since I have the fix.

Comment 6

[Harshal Pradhan]

Comment on attachment 131723 [details] [diff] [review]
Fix ?

This is a really simple one-liner that fixes a purify UMR. 

(Hoping sfarser is around. I'm not really know who does editor sr's these
days.)

Comment 7

[Harshal Pradhan]

Thanks for the quick reviews. Checked in.