219713 - NSS trunk build fails on all platforms except Windows

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Wan-Teh Chang]

NSS trunk build fails on all platforms except Windows.

The error message is:

cc -o SunOS5.8_64_DBG.OBJ/atob -g -KPIC -DSVR4 -DSYSV -D__svr4 -D__svr4__
-DSOLARIS -D_REENTRANT -DSOLARIS2_8 -D_SVID_GETTOD -xarch=v9 -xs -DXP_UNIX
-DNSPR20 -DDEBUG -UNDEBUG -DDEBUG_svbld -I/usr/dt/include -I/usr/openwin/include
-I../../../../dist/SunOS5.8_64_DBG.OBJ/include  -I../../../../dist/public/nss 
-I../../../../dist/private/nss  -I../../../../dist/public/seccmd
-I../../../../dist/public/dbm  SunOS5.8_64_DBG.OBJ/atob.o 
../../../../dist/SunOS5.8_64_DBG.OBJ/lib/libsectool.a 
-L../../../../dist/SunOS5.8_64_DBG.OBJ/lib -lssl3 -lsmime3 -lnss3 -lplc4 -lplds4
-lnspr4  -lthread -lnsl -lsocket -lposix4 -ldl -lc 
ild: (undefined symbol) CERT_TimeChoiceTemplate -- referenced in
../../../../dist/SunOS5.8_64_DBG.OBJ/lib/libsmime3.so
NEXT ERROR gmake[2]: *** [SunOS5.8_64_DBG.OBJ/atob] Error 5

I believe the fix is to add a line:

+;;CERT_TimeChoiceTemplate DATA ;

to lib/nss/nss.def.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

Comment 2

[Wan-Teh Chang]

Comment on attachment 131758 [details] [diff] [review]
Proposed patch

Nelson, is this the right way to export an ASN.1 template
for both Unix and Windows?

>+;;CERT_TimeChoiceTemplate DATA ;
> NSS_Get_CERT_TimeChoiceTemplate;

Is there anything else we need to do?  I seem to recall
that we need to declare these templates with some macro.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 131758 [details] [diff] [review]
Proposed patch

Yes, This appears to be the right way to do it.  r=MisterSSL

I suspect you're thinking of the macros
SEC_ASN1_CHOOSER_DECLARE and SEC_ASN1_CHOOSER_IMPLEMENT

Comment 4

[Wan-Teh Chang]

Yes, those are the macros I was thinking of.  I
verified that they are being used in lib/certdb/certt.h
and lib/util/sectime.c.

I've checked in this patch.  Marked the bug fixed.

Comment 5

[Julien Pierre]

Sorry about the build failure. I haven't been building on any other platform
than windows lately.