219795 - Add menu item for address book

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[mozilla]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.1.4322)
Build Identifier: 

No menu item for address book.
Thunderbird 0.3a

Reproducible: Always

Steps to Reproduce:

Comment 1

[xolaware.llc]

also a problem on mac, but since i'm not owner, i cannot change target hardware for this bug.

Comment 2

[Asa Dotzler [:asa]]

This is not a bug.

Comment 3

[mozilla]

Why "not a bug"?
This is bug!

Comment 4

[WADA:World Anti-bad-Duping Agency]

[e-mail], why this is bug?

"Address book menu" is moved to "Address book button in toolbar" and this is
only a UI change of Thunderbird from Mozilla Mail&News.
A word "bug" is generally used for defect/fault/flaw although all requests in
Bugzilla is also called "bug".
Asa says "this is not a defect".  

If your "bug" means "a valid bug in Bugzilla", changing "Severity=Enhancement",
I think, is your appropriate action since your request is "design change".
Please describe the reason why "Address book menu" is required in addition to
"Address book button in toolbar".

I guess you love keyboard only operation or you uses notebook PC and you are not
a specialist in using touchpad/trackpoint/trackball like me :-)
Isn't it right?

Comment 5

[mozilla]

> Please describe the reason why "Address book menu" is required in addition to
> "Address book button in toolbar".

It's simple.
1) Toolbar is optional. For example, I am don't use toolbar. And toolbar is not visible on my configuration.
2) User may don't have mouse.

> If your "bug" means "a valid bug in Bugzilla", 
> changing "Severity=Enhancement",

IMHO, severity is "normal".

Comment 6

[Don Crandall]

In additions to comment 5, above: The toolbar is also customizable. This means
that the Address book button can be removed from the toolbar, leaving no way to
instatiate an AB window.

Comment 7

[Simon Paquet [:sipaq]]

This is a enhancement request.

Comment 8

[Robert Accettura [:raccettura]]

Attachment: Patch v1

We will unquestionably need a second patch, but to get this going.

Comment 9

[Robert Accettura [:raccettura]]

Comment on attachment 145663 [details] [diff] [review]
Patch v1

Scott,

This ultimately comes down to you anyway... so I see 2 issues:

1.  Positioning?  Should I take "Search Addresses" and put that and "Address
Book" between 2 separators as their own little section of the menu?  

Second obvious problem is the accesskey (we would now have 2 that use A)?  Who
wins? 

Other than that, only changes in this patch are spacing, because those long
lines drive me nuts.

Comment 10

[Adam Becevello]

*** Bug 250333 has been marked as a duplicate of this bug. ***

Comment 11

[Robert Accettura [:raccettura]]

mscott:  ping

Can you look at this, it's pretty minor.

Comment 12

[sairuh (rarely reading bugmail)]

nominating for 1.0. from an accessibility p.o.v. it'd be great to have AB
available in the menu, since the toolbar isn't keyboard accessible.

Comment 13

[sairuh (rarely reading bugmail)]

(In reply to comment #9)
> Second obvious problem is the accesskey (we would now have 2 that use A)?  Who
> wins? 

I would suggest B (Address _Book) or the first d (A_ddress Book).

However, would it be possible to grab these access keys from an existing
location so as to avoid localization issues? If not, how difficult would it be
to localize this change? I'm tentatively nominating for PR, due to the possible
l10n needs.

Comment 14

[Scott MacGregor]

scheduling for 0.9.

Comment 15

[Scott MacGregor]

Attachment: the fix (based on Robert's patch)

Comment 16

[Scott MacGregor]

fixed branch and trunk

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

v.

Comment 18

[Scott MacGregor]

*** Bug 267144 has been marked as a duplicate of this bug. ***

Comment 19

[Scott MacGregor]

*** Bug 259653 has been marked as a duplicate of this bug. ***