219944 - Junk Mail Icon could use some spacing in the "About Junk Mail" dialog

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan Borggraefe]

There is no spacing between the description and the small Junk Mail Icon in this
dialog. This looks ugly. See screenshots for details.

Comment 1

[Stefan Borggraefe]

Attachment: Shows the bug.

Comment 2

[Stefan Borggraefe]

Attachment: Fix

Adds margin-left: 0.5ex to classic and 0.3ex to modern. Modern needs less
margin, because the icon itself already has a blank area on the left.

Comment 3

[[e-mail]]

Hmmm... I think the Modern icon is ok, though...

Comment 4

[[e-mail]]

Comment on attachment 132182 [details] [diff] [review]
Fix

Well, classic is definitely improved; the change for modern is less obvious,
you must have been measuring pixels with a ruler or something ;-)

Comment 5

[Stefan Borggraefe]

Comment on attachment 132182 [details] [diff] [review]
Fix

David: I hope this is MailNews enough so you can sr it, even though it is filed
in Browser/Themes. ;-)

Comment 6

[David :Bienvenu]

Comment on attachment 132182 [details] [diff] [review]
Fix

this  is in messenger so it's fine, but in any case, sr's can review anywhere -
it's just that one of the reviewers needs to be a module owner.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Checking in themes/classic/messenger/primaryToolbar.css;
/cvsroot/mozilla/themes/classic/messenger/primaryToolbar.css,v  <-- 
primaryToolbar.css
new revision: 1.9; previous revision: 1.8
done
Checking in themes/modern/messenger/primaryToolbar.css;
/cvsroot/mozilla/themes/modern/messenger/primaryToolbar.css,v  <-- 
primaryToolbar.css
new revision: 1.14; previous revision: 1.13
done