Closed
Bug 220062
Opened 21 years ago
Closed 21 years ago
Cleanup NS_METHOD_GETTER_STR/NS_METHOD_SETTER_STR
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
971 bytes,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
Both methods return NS_OK on OOM. The setter uses PR_FREEIF(_member) before clobbering _member.
Attachment #131988 -
Flags: review?(dougt)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 131988 [details] [diff] [review] nullcheck strdup and use PR_Free to save a _member = nsnull; as long as your touching it, line up the trailing \'s. I don't understand why you can't use PR_FREEIF. but not using it is, i guess, okay here. r=dougt
Attachment #131988 -
Flags: review?(dougt) → review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•