Closed Bug 220092 Opened 21 years ago Closed 21 years ago

[ActiveX] Make edit mode work a bit

Categories

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adamlock, Assigned: adamlock)

Details

Attachments

(1 file, 1 obsolete file)

The editor mode in control has been broken for ages, update it to work with the
latest editing session interfaces.
Attached patch Patch (obsolete) — Splinter Review
Patch enables basic editor mode with italic, bold and underline functionality
via IE DHTML commands.
Attached patch Patch (detabbed)Splinter Review
Same again without the tabs
Attachment #131991 - Attachment is obsolete: true
Comment on attachment 131993 [details] [diff] [review]
Patch (detabbed)

Requesting r/sr on this patch to re-enable very basic editing functionality
using the modern editor interfaces. Patch also updates a few comments.
Attachment #131993 - Flags: superreview?(bz-vacation)
Attachment #131993 - Flags: review?(blizzard)
Attachment #131993 - Flags: review?(blizzard) → review+
Comment on attachment 131993 [details] [diff] [review]
Patch (detabbed)

>Index: mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp
>+    if (localFile)
>+        return localFile->QueryInterface(NS_GET_IID(nsIFile), (void**) _retval);

return CallQueryInterface(localFile, _retval);

sr=bzbarsky with that nit.
Attachment #131993 - Flags: superreview?(bzbarsky) → superreview+
Fix is checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: