Closed
Bug 220106
Opened 21 years ago
Closed 21 years ago
@mozilla.org/security/nsCertTree;1 doesn't null check mTreeArray
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
(Keywords: crash)
Attachments
(1 file)
|
3.93 KB,
patch
|
KaiE
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Create @mozilla.org/security/nsCertTree;1 in xpcshell, interogate it
for interfaces and then access various properties. you will crash.
Attachment #132006 -
Flags: superreview?(bz-vacation)
Attachment #132006 -
Flags: review?(kaie)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 132006 [details] [diff] [review]
nullcheck
sr=bzbarsky
Attachment #132006 -
Flags: superreview?(bz-vacation) → superreview+
|
||
Comment 3•21 years ago
|
||
Comment on attachment 132006 [details] [diff] [review]
nullcheck
Looks ok. In ::IsContainerEmpty, you could return NS_ERROR_NOT_INITIALIZED,
too, for consistency with your other changes. r=kaie with or without this
change.
Attachment #132006 -
Flags: review?(kaie) → review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•