Closed Bug 220106 Opened 21 years ago Closed 21 years ago

@mozilla.org/security/nsCertTree;1 doesn't null check mTreeArray

Categories

(Core Graveyard :: Security: UI, defect)

Other Branch
x86
BeOS
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

(Keywords: crash)

Attachments

(1 file)

Create @mozilla.org/security/nsCertTree;1 in xpcshell, interogate it
for interfaces and then access various properties. you will crash.
Attached patch nullcheckSplinter Review
Attachment #132006 - Flags: superreview?(bz-vacation)
Attachment #132006 - Flags: review?(kaie)
Comment on attachment 132006 [details] [diff] [review]
nullcheck

sr=bzbarsky
Attachment #132006 - Flags: superreview?(bz-vacation) → superreview+
Comment on attachment 132006 [details] [diff] [review]
nullcheck

Looks ok. In ::IsContainerEmpty, you could return NS_ERROR_NOT_INITIALIZED,
too, for consistency with your other changes. r=kaie with or without this
change.
Attachment #132006 - Flags: review?(kaie) → review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: PSM → Core
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: