220111 - nsIDownload should indicate that Init must be called

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

related: bug 220103

In my opinion, nsIDownload should make it clear that its Init function must be
called prior to doing anything else with this interface, to reflect the
behaviour of nsDownloadProxy.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 132007 [details] [diff] [review]
patch

ok opinions on this change?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132007 [details] [diff] [review]
patch

Looks good to me.

Comment 4

[Darin Fisher]

Comment on attachment 132007 [details] [diff] [review]
patch

>Index: base/nsIDownload.idl

>      * Initializes the download with certain properties.
>+     * This function must be called prior to accessing any properties on this
>+     * interface.

       * Initializes the download with certain properties.  This function must
       * be called prior to accessing any properties on this interface.

nit pick... seems better to write the comment as a complete paragraph.	but,
sr=darin either way.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, with that change made

Checking in base/nsIDownload.idl;
/cvsroot/mozilla/uriloader/base/nsIDownload.idl,v  <--  nsIDownload.idl
new revision: 1.6; previous revision: 1.5
done