220198 - helperappservice qi's to httpchannel when it wants encodedchannel

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsExternalHelperAppService.cpp:
  nsCOMPtr<nsIHttpChannel> httpChannel = do_QueryInterface( aChannel );
  if (httpChannel) 
  {
    // Turn off content encoding conversions if needed
[... some stuff not involving httpChannel...]
    nsCOMPtr<nsIEncodedChannel> encodedChannel(do_QueryInterface(httpChannel));
    NS_ENSURE_TRUE(encodedChannel, NS_ERROR_UNEXPECTED);
    encodedChannel->SetApplyConversion( applyConversion );
  }

this should really directly qi to nsIEncodedChannel, instead of via httpChannel

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132085 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.220; previous revision: 1.219
done