220220 - make UA string depend on config/milestone.txt

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Making the UA string depend on config/milestone.txt will make it easier to bump
the version number, especially now that we have to change all.js for all the
various apps.

I prefer the idea of hard-coding the version in HTTP over having a pref,
although we could have an additional pref file.  I prefer hard-coding since I'd
rather the UA-string version not be an API that it looks like embedders
can/should change (or forget to change!).

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

This hardcodes the UA string version using the MOZILLA_VERSION macro and
removes checking the general.useragent.misc pref but leaves the GetMisc /
SetMisc API on nsIHttpProtocolHandler.

It also fixes a variable-shadowing warning in nsHttpHandler.cpp.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

The MAPI code looks unused, so I removed it, but it wouldn't be too hard to fix
(and make it always use the Mozilla version, although who knows what it was
intended to be used for if it's unused).

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2003-09-24 22:39 -0700.