220303 - Need to tidy up onclick/listeners in mail/news windows

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

Currently we both listen for click events and use onclick within
mail3PaneWindowVertLayout.xul, messageWindow.xul and messenger.xul would be good
to tidy these up into a simple onclick.

Comment 1

[Ian Neal]

Accepting

Comment 2

[Ian Neal]

Attachment: Patch v0.1 to tidy up listener/onclick

This patch tidies up how we look for a click and addresses the issue of an
exception being thrown in a listener when we click on an illegal link, by
removing the listener and changing the function that onclick calls to be an
amended version of the listener's original function that in turn calls the
onclick's original function.

Comment 3

[[e-mail]]

Comment on attachment 132162 [details] [diff] [review]
Patch v0.1 to tidy up listener/onclick

This is just extracted from another patch that I already gave r= to, right?

Comment 4

[Ian Neal]

Yep ;-)

Comment 5

[David :Bienvenu]

Comment on attachment 132162 [details] [diff] [review]
Patch v0.1 to tidy up listener/onclick

sr=bienvenu

Comment 6

[Ian Neal]

Fixed checked in by timeless, thank you timeless.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED via code inspection through LXR, and the fact that this works regression-free.