220418 - Crash during txExecutionState::init

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We can sometimes crash in the txExecutionState during init since we call
findTemplate to find the initial template too early. The problem is that
findTemplate might call back into us during the patternmatching (in particular
it might ask for the recycler) which isn't set up yet.

The fix is to move the code to set up initial template to last in
txExecutionState::init. Patch comming up.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 132235 [details] [diff] [review]
patch to fix

>+    pushTemplateRule(frame, nullName, nsnull);
>+    rv = runTemplate(templ);
>+    NS_ENSURE_SUCCESS(rv, rv);
> 
>     return NS_OK;
> }

Just |return runTemplate(templ);|

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

patch checked in, thanks for reviews