Closed
Bug 220418
Opened 21 years ago
Closed 21 years ago
Crash during txExecutionState::init
Categories
(Core :: XSLT, defect)
Core
XSLT
Tracking
()
RESOLVED
FIXED
People
(Reporter: sicking, Assigned: sicking)
Details
(Keywords: crash)
Attachments
(1 file)
|
2.38 KB,
patch
|
axel
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
We can sometimes crash in the txExecutionState during init since we call
findTemplate to find the initial template too early. The problem is that
findTemplate might call back into us during the patternmatching (in particular
it might ask for the recycler) which isn't set up yet.
The fix is to move the code to set up initial template to last in
txExecutionState::init. Patch comming up.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #132235 -
Flags: superreview?(peterv)
Attachment #132235 -
Flags: review?(axel)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 132235 [details] [diff] [review]
patch to fix
>+ pushTemplateRule(frame, nullName, nsnull);
>+ rv = runTemplate(templ);
>+ NS_ENSURE_SUCCESS(rv, rv);
>
> return NS_OK;
> }
Just |return runTemplate(templ);|
Attachment #132235 -
Flags: superreview?(peterv) → superreview+
|
||
Updated•21 years ago
|
Attachment #132235 -
Flags: review?(axel) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
patch checked in, thanks for reviews
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•