220562 - Camino build busted. Fixes applied to widget/src/mozilla not applied to widget/src/cocoa

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Andrew Thompson]

JST made some changes to nsIContent.h, and fixed mac build bustage as decribed here:

http://bonsai.mozilla.org/cvsquery.cgi?branch=HEAD&file=mozilla/widget/src/mac/&date=week

(Changes for Spet 26th, if you look at this URL more than a week from then).

Unfortunately the same changes weren't applied in widget/src/camino, so camino
is busted, but all of the Tinderboxes are down! So no one noticed, it seems.

I also found this problem:

nsMenuX.cpp: In member function `virtual nsresult nsMenuX::AddMenu(nsIMenu*)':
nsMenuX.cpp:344: error: non-lvalue in unary `&'
nsMenuX.cpp: In member function `virtual nsresult nsMenuX::RemoveAll()':
nsMenuX.cpp:422: warning: comparison between signed and unsigned integer 
   expressions

which seems to be a problem building with GCC 3.3 that's fixed in widget/src/mac
but not widget/src/cocoa.

I'll follow up with some patches presently.

Comment 1

[Andrew Thompson]

Attachment: Applies changes made to widget/src/mac to widget/src/cocoa & applied a gcc 3.3 fix

Comment 2

[Simon Fraser [no longer active]]

Comment on attachment 132311 [details] [diff] [review]
Applies changes made to widget/src/mac to widget/src/cocoa & applied a gcc 3.3 fix

Does GetChildAt() not addref?

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 132311 [details] [diff] [review]
Applies changes made to widget/src/mac to widget/src/cocoa & applied a gcc 3.3 fix

Nope, not any more. If you want strong references from GetChildAt(), assign the
return value into a nsCOMPtr, if not, we don't waste time refcounting.

sr=jst. Sorry for not catching this when checking in.

Comment 4

[Mike Pinkerton (not reading bugmail)]

fixes landed. /me boggles at the api change.

Comment 5

[waverider]

Attachment: build error log 2003100101

Building mozilla part succeeded. but Building Camino part don't succeed.
Dec2002 Devtool and August2003-gcc3.3Updater

Comment 6

[Mike Pinkerton (not reading bugmail)]

yeah, i just noticed that. anyone want to put up a patch for camino? i may be
able to get to it this afternoon, but probably not.

Comment 7

[Ludovic Hirlimann [:Usul]]

I am working on a paper poatch at work I can't code really. WIll try to put
somethin on tonight.

Comment 8

[Ludovic Hirlimann [:Usul]]

Attachment: last files needed to fix the bustage

I'de like to thanks [e-mail] for applying the first files. I'm
dumb because I missed this last file.

Comment 9

[Ludovic Hirlimann [:Usul]]

Attachment: comment delete , that's better

sent to brian so He can, apply it

Comment 10

[Ludovic Hirlimann [:Usul]]

brian did the chek-in. Bustage gone.

Verified.

Comment 11

[Ludovic Hirlimann [:Usul]]

.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 132311 [details] [diff] [review]
Applies changes made to widget/src/mac to widget/src/cocoa & applied a gcc 3.3 fix

We have a new Camino request flag which can be set multiple times for a patch.
Moving old review requests to the new flag. Sorry for the spam.