220653 - Wrong total cell width with table-layout: fixed + colspan + cellspacing

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Chris Browet]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20030916
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20030916

Using a fixed layout table and TD + COLSPAN, the size of the cells are wrongly
calculated. Looking at the code, it looks like the width of the table available
to cells is decreased by (numColumns * cellspacing), without taking the colspan
variable into account. This leads (as showned in the test case) to the total
width of cells < width of table.
Setting CELLSPACING=0 works around the problem.

IE and KHTML do not show the problem. Problem occurs in 1.4 linux and 1.5rc2 in
windows.

Reproducible: Always

Steps to Reproduce:
1. Set the table style to "table-layout: fixed"
2. Set the table's CELLSPACING > 0
3. Use COLSPAN > 1 on TD level

Actual Results:  
Total of cells width < Table width

Expected Results:  
Cells should be flowed as to fill the table

Comment 1

[José Jeria]

Cant you attach a testcase? I get a "401 Authorization Required" on the URL.

Comment 2

[Chris Browet]

Attachment: Test Case

Comment 3

[Bernd]

mine

Comment 4

[Bernd]

Attachment: patch

Comment 5

[Bernd]

Attachment: one more cellspacing please

we need one more cellspacing

Comment 6

[Bernd]

Comment on attachment 133704 [details] [diff] [review]
one more cellspacing please

Boris could you review again

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 133704 [details] [diff] [review]
one more cellspacing please

Where is mCellSpacingTotal declared?  Is it even a member?  If no, call it
cellSpacingTotal or something...

r=bzbarsky with that sorted out.

Comment 8

[Bernd]

its a member variable
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/BasicTableLayoutStrategy.h#251

Comment 9

[Bernd]

the patch has been checked in on Oct. 21th