220672 - consider nsIUTF8StringEnumerator for nsIEncodedChannel

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

As nsIEncodedChannel::contentEncodings is really just a list of strings, using
nsIUTF8StringEnumerator would be more friendly for callers of this interface.

http://lxr.mozilla.org/seamonkey/source/xpcom/ds/nsIStringEnumerator.idl#52

Comment 1

[Darin Fisher]

agreed.  patches welcome :)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, taking... but I don't know when I'll get to this...

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

(not tested yet)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 132648 [details] [diff] [review]
patch

ok, tested the only caller (Save link target as), and it works

Comment 5

[Darin Fisher]

Comment on attachment 132648 [details] [diff] [review]
patch

>Index: netwerk/protocol/http/src/nsHttpChannel.cpp

>+nsHttpChannel::nsContentEncodings::GetNext(nsACString& aNextEncoding)
...
>     PRBool haveType = PR_FALSE;
>     if (CaseInsensitiveFindInReadable(NS_LITERAL_CSTRING("gzip"),
>                                       start,
>                                       end)) {
>+        aNextEncoding = NS_LITERAL_CSTRING(APPLICATION_GZIP);
>         haveType = PR_TRUE;
>     }
> 
>     if (!haveType) {
>         encoding.BeginReading(start);
>         if (CaseInsensitiveFindInReadable(NS_LITERAL_CSTRING("compress"),
>                                           start,
>                                           end)) {
>+            aNextEncoding = NS_LITERAL_CSTRING(APPLICATION_COMPRESS);
>                                            
>             haveType = PR_TRUE;
>         }
>     }
>     
>     if (! haveType) {
>         encoding.BeginReading(start);
>         if (CaseInsensitiveFindInReadable(NS_LITERAL_CSTRING("deflate"),
>                                           start,
>                                           end)) {
>+            aNextEncoding = NS_LITERAL_CSTRING(APPLICATION_ZIP);
>             haveType = PR_TRUE;
>         }
>     }

seems like this code could be compacted into a loop to save footprint.
something for later perhaps.

r=darin

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132648 [details] [diff] [review]
patch

sr=bzbarsky

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in
filed Bug 221290 for that loop suggestion